Merged
Conversation
* When a controller is stopped (either by pressing corrsponding `Shutdown` button or when enabling the winter mode) any paused and queued valves are reset. An use case is to shutdown a watering cycle with valves paused, when the cycle should not be running (e.g. started by mistake but paused due to tank being empty).
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to reset paused valves when sprinkler controllers are stopped, either through the shutdown buttons or when enabling winter mode. This ensures that any paused and queued valves are properly reset when stopping a watering cycle.
- Introduces a reusable script template for resetting controllers that both shuts down and resets resume state
- Replaces direct
sprinkler.shutdowncalls with the new reset script in button actions - Updates winter mode activation to use the new reset functionality for both controllers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| script_reset_controller.yaml | New template script that shuts down controller and resets resume state |
| controllers.yaml | Updated shutdown buttons and winter mode to use the new reset script instead of direct shutdown calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…shutdown(true)` call, which also clears any queued values in the sprinkler controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutdownbutton or when enabling the winter mode) any paused and queued valves are reset. An use case is to shutdown a watering cycle with valves paused, when the cycle should not be running (e.g. started by mistake but paused due to tank being empty).